backend/src/main/java/djmil/cordacheckers/cordaclient/CordaClient.java

@@ -40,7 +40,7 @@ public class CordaClient {
         this.jsonMapper = jsonMapper;
     }
 
-    public List<VirtualNode> fetchVirtualNodeList() {
+    public List<VirtualNode> getVirtualNodeList() {
         ResponseEntity<VirtualNodeList> resp = this.restTemplate.exchange(
             "/virtualnode",
             HttpMethod.GET, 

backend/src/main/java/djmil/cordacheckers/cordaclient/dao/HoldingIdentity.java

@@ -34,28 +34,4 @@ public record HoldingIdentity(String x500Name, String shortHash) implements Seri
 
         return false;
     }
-
-    public boolean isCustodian() throws InvalidNameException {
-        LdapName ln = new LdapName(x500Name);
-
-        for(Rdn rdn : ln.getRdns()) {
-            if(rdn.getType().equalsIgnoreCase("OU")) {
-                return rdn.getValue().toString().equalsIgnoreCase("Custodian");
-            }
-        }
-
-        return false;
-    }
-
-    public boolean isCordaCheckers() throws InvalidNameException {
-        LdapName ln = new LdapName(x500Name);
-
-        for(Rdn rdn : ln.getRdns()) {
-            if(rdn.getType().equalsIgnoreCase("O")) {
-                return rdn.getValue().toString().equalsIgnoreCase("Checkers");
-            }
-        }
-
-        return false;
-    }
 }

backend/src/main/java/djmil/cordacheckers/user/HoldingIdentityResolver.java

@@ -5,6 +5,8 @@ import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 
+import javax.naming.InvalidNameException;
+
 import org.springframework.stereotype.Service;
 
 import djmil.cordacheckers.cordaclient.CordaClient;
@@ -20,49 +22,45 @@ public class HoldingIdentityResolver {
      *  Ideally, we want to be able to force update cache, had the corda
      *  cluster configuration changed (aka in case of a cache miss)
      */ 
-    Map<String, HoldingIdentity> player; // PlayerName to ShortHash
+    final Map<String, HoldingIdentity> cache; // PlayerName to ShortHash
-    HoldingIdentity custodian;
 
     HoldingIdentityResolver(CordaClient cordaClient) {
-        this.player = new HashMap<>();
+        this.cache = setCache(cordaClient);
-
-        fetchVNodeList(cordaClient);
     }
 
-    private void fetchVNodeList(CordaClient cordaClient) {
+    private static Map<String, HoldingIdentity> setCache(CordaClient cordaClient) {
-        final List<VirtualNode> vnodeList = cordaClient.fetchVirtualNodeList();
+        Map<String, HoldingIdentity> map = new HashMap<>();
 
-        for (VirtualNode vNode : vnodeList) {
+        try {
-            final var identity = vNode.holdingIdentity();
+            List<VirtualNode> vNodeList = cordaClient.getVirtualNodeList();
-            try {            
-                if (!identity.isCordaCheckers())
-                    continue;
 
-                if (identity.isPlayer())
+            for (VirtualNode vNode : vNodeList) {
-                    player.put(identity.getName().toLowerCase(locale), identity);
+                var identity = vNode.holdingIdentity();
 
-                if (identity.isCustodian())
+                if (identity.isPlayer()) {
-                    custodian = identity; // <<-- there shall be only one custodian
+                    map.put(
+                        identity.getName().toLowerCase(locale), 
+                        identity
+                        );
+                }
             }
-            catch (Exception e) {
+        } catch (InvalidNameException e) {
-                System.err.println("Incomprehensible VirtualNode identity " +identity);
+            // TODO: logs
-            } 
+            System.out.println("Unable to get ShorHash list of Corda VirtualNodes: "+e.getMessage());
         }
+
+        return map;
     }
 
     /*
      * @param playerName 
      *  HoldingIdentity x500 name typically looks like 
-     *  "CN=Bob, OU=Player, O=Checkers, L=Kyiv, C=UA"
+     *  "CN=Bob, OU=Player, O=Checkers, L=Kviv, C=UA"
      *  CN - is a common name, expected to be unique for CordaCheckers setup.
      * 
      * @return HoldingIdentity
      */
     public HoldingIdentity getByUsername(String userName) {
-        return this.player.get(userName.toLowerCase(locale));
+        return this.cache.get(userName.toLowerCase(locale));
-    }
-
-    public HoldingIdentity getCustodian() {
-        return this.custodian;
     }
 }

corda/build.gradle

@@ -20,7 +20,7 @@ allprojects {
         cordaClusterURL = "https://localhost:8888"
         networkConfigFile = "config/static-network-config.json"
         r3RootCertFile = "config/r3-ca-key.pem"
-        corDappCpiName = "CordaCheckers"
+        corDappCpiName = "MyCorDapp"
         notaryCpiName = "NotaryServer"
         cordaRpcUser = "admin"
         cordaRpcPasswd ="admin"
@@ -60,7 +60,8 @@ publishing {
             artifactId "corda-CSDE-java-sample"
             groupId project.group
             artifact jar
-        }
     }
+
+   }
 }
 

corda/config/static-network-config.json

@@ -1,19 +1,19 @@
 [
   {
     "x500Name" : "CN=Alice, OU=Player, O=Checkers, L=Zug, C=CH",
-    "cpi" : "CordaCheckers"
+    "cpi" : "MyCorDapp"
   },
   {
-    "x500Name" : "CN=Bob, OU=Player, O=Checkers, L=Kyiv, C=UA",
+    "x500Name" : "CN=Bob, OU=Player, O=Checkers, L=Kviv, C=UA",
-    "cpi" : "CordaCheckers"
+    "cpi" : "MyCorDapp"
   },
   {
     "x500Name" : "CN=Charlie, OU=Player, O=Checkers, L=London, C=GB",
-    "cpi" : "CordaCheckers"
+    "cpi" : "MyCorDapp"
   },
   {
-    "x500Name" : "CN=Kumar, OU=Custodian, O=Checkers, L=Mumbai, C=IN",
+    "x500Name" : "CN=Kumar, OU=Player, O=Checkers, L=Mumbai, C=IN",
-    "cpi" : "CordaCheckers"
+    "cpi" : "MyCorDapp"
   },
   {
     "x500Name" : "CN=NotaryRep1, OU=Test Dept, O=R3, L=London, C=GB",